Implement headteacher salaries (merge into existing Salaries PR) #4034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ruby
Sarah-DfE
reviewed
Jun 27, 2024
There was a problem hiding this comment.
@gemmadallmandfe The variables all look good to me. I've changed the wording 'to' to 'and', as in 'between £X and £X'
app/views/content/landing/how-much-do-teachers-get-paid/_content.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/landing/what-teaching-taught-me/_content.html.erb
Outdated
Show resolved
Hide resolved
|
Review app deployed to https://get-into-teaching-app-review-4034.test.teacherservices.cloud |
|
gemmadallmandfe
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
Removing Trello card as it appears to be failing on the pipeline.
Context
We're centralising monetary values in one place.
Changes proposed in this pull request
Pages with changes:
https://get-into-teaching-app-review-4034.test.teacherservices.cloud/is-teaching-right-for-me/teacher-pay-and-benefits#headteacher-salary
https://get-into-teaching-app-review-4034.test.teacherservices.cloud/landing/careers
https://get-into-teaching-app-review-4034.test.teacherservices.cloud/landing/grow
https://get-into-teaching-app-review-4034.test.teacherservices.cloud/landing/how-much-do-teachers-get-paid
https://get-into-teaching-app-review-4034.test.teacherservices.cloud/landing/what-teaching-taught-me
This merges into an existing branch.
I've made a few of these, so there may be merge conflicts in the salaries.yml file (relating to the heading of 'Implemented below this line'.
You'll need to ensure you're happy with the ordering of headings before you merge the main PR.
Guidance to review
Pre-election period restrictions