Variables for Non-uk-visa-thresholds #4061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://get-into-teaching-app-review-4061.test.teacherservices.cloud |
|
| * outer London, you must earn £34,514 | ||
| * London fringe, you must earn £31,350 | ||
| * the rest of England, you must earn £30,000 | ||
| * inner London, you must earn $salaries_skilledworkerteacherfulltimemin_innerlondon$ |
There was a problem hiding this comment.
@Sarah-DfE I think the idea was that we would move these variables to the nonuk variables file
This means we will need to:
Before #4035 is merged to production:
- take out these changes from Update unqualified teacher and visa thresholds as variables (Merge into existing Salaries PR) #4035
- take out these variables from the nonuk config file in Update unqualified teacher and visa thresholds as variables (Merge into existing Salaries PR) #4035
After #4035 is merged to production and after all other variable PRs are merged to production:
- add a change here to add these salary thresholds into the nonuk variables file
- update all the variable references in this PR to have
nonukrather thansalariesat the front
I'll set this PR to draft for now - let's come back to it and work through it together!
|
Closing this PR - will be replaced by a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
Context
Changes proposed in this pull request
Guidance to review
https://get-into-teaching-app-review-4061.test.teacherservices.cloud/non-uk-teachers/visas-for-non-uk-teachers
https://get-into-teaching-app-review-4035.test.teacherservices.cloud/non-uk-teachers/visas-for-non-uk-trainees
Pre-election period restrictions