Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assessment Only spreadsheet upload #4269

Merged
merged 17 commits into from
Nov 21, 2024
Merged

Assessment Only spreadsheet upload #4269

merged 17 commits into from
Nov 21, 2024

Conversation

martyn-w
Copy link
Contributor

Trello card

spreadsheet upload functionality for AO provider listings

Context

Building on the spreadsheet upload functionality for teaching internships, this provides a facility to upload Assessment Only providers

Changes proposed in this pull request

Guidance to review

@github-actions github-actions bot added ruby Pull requests that update Ruby code test labels Oct 22, 2024
@martyn-w martyn-w changed the title Ao spreadsheet Assessment Only spreadsheet upload Oct 22, 2024
@gemmadallmandfe
Copy link
Contributor

@gemmadallmandfe
Copy link
Contributor

@martyn-w As discussed, I have added a new column to the spreadsheet with a clickable phone number

the new column is called international_phone (but happy to change this, particularly if you can think of a one-word column name to be consistent with all the others)

@github-actions github-actions bot added the content Content changes label Nov 12, 2024
@gemmadallmandfe
Copy link
Contributor

@martyn-w In prod, National is listed at the end of the regions and before Non-UK, rather than in the middle of the regions alphabetically

Would it be possible to replicate this?

Prod
image

@martyn-w martyn-w marked this pull request as ready for review November 13, 2024 09:39
@github-actions github-actions bot added the Style label Nov 14, 2024
spencerldixon
spencerldixon previously approved these changes Nov 18, 2024
Copy link
Collaborator

@spencerldixon spencerldixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@gemmadallmandfe
Copy link
Contributor

@martyn-w One final change and this can go out on Thursday!

Could you possibly shift the National section again so it is first in the list (ie above East of England)?

I also need to give you one final spreadsheet to upload - and then this can be merged

Copy link

Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@martyn-w martyn-w merged commit 26d0330 into master Nov 21, 2024
26 checks passed
@martyn-w martyn-w deleted the ao-spreadsheet branch November 21, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content changes Review ruby Pull requests that update Ruby code Style test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants