Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update engineers teach physics #4333

Merged
merged 9 commits into from
Nov 25, 2024
Merged

Conversation

joegibb
Copy link
Collaborator

@joegibb joegibb commented Nov 6, 2024

https://trello.com/c/UF2QP467

update engineers teach physics page with new components

@github-actions github-actions bot added ruby Pull requests that update Ruby code content Content changes labels Nov 6, 2024
@github-actions github-actions bot added the Review label Nov 6, 2024
Copy link
Collaborator

@Sarah-DfE Sarah-DfE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments for you @joegibb

@gemmadallmandfe
Copy link
Contributor

If we have now decided to capitalise Engineers teach physics, we need to apply that change to the physics page as well

/life-as-a-teacher/explore-subjects/physics

image

Copy link

Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@joegibb joegibb merged commit 8fe2f21 into master Nov 25, 2024
26 checks passed
@joegibb joegibb deleted the update-engineers-teach-physics branch November 25, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content changes Review ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants