Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create English subject page #4337

Merged
merged 10 commits into from
Nov 19, 2024
Merged

create English subject page #4337

merged 10 commits into from
Nov 19, 2024

Conversation

joegibb
Copy link
Collaborator

@joegibb joegibb commented Nov 7, 2024

https://trello.com/c/aOTV5CHu

Create a subject page for English

@github-actions github-actions bot added ruby Pull requests that update Ruby code content Content changes labels Nov 7, 2024
@github-actions github-actions bot added the Review label Nov 7, 2024
@joegibb joegibb requested a review from martyn-w November 7, 2024 12:58
Copy link
Collaborator

@Sarah-DfE Sarah-DfE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few little comments @joegibb looking good tho!

Copy link
Collaborator

@Sarah-DfE Sarah-DfE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few super small tweaks @joegibb

Copy link

Copy link
Collaborator

@Sarah-DfE Sarah-DfE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@joegibb joegibb merged commit a617c87 into master Nov 19, 2024
26 checks passed
@joegibb joegibb deleted the create-english-subject-page branch November 19, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content changes Review ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants