Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added manual pages to last mod tracking #4383

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

spencerldixon
Copy link
Collaborator

Trello card

https://trello.com/c/e7N621jD/7017-investigate-lastmod-date-for-non-standard-content-pages

Context

We recently changed how we assign lastmod date to the pages in our sitemap (see attached ticket)

There are a few non-standard content pages that are still using the old default date of 2021-03-01

/events/about-get-into-teaching-events
/events
/mailinglist/signup/name

We want to investigate these and tweak the lastmod process if possible (or change which default date they use)

Changes proposed in this pull request

  • Merge in a set of manual paths with empty frontmatter to the list of pages that lastmod iterates through

Guidance to review

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Nov 29, 2024
@spencerldixon spencerldixon force-pushed the feature/track_additional_paths_with_lastmod branch from d24126e to c210fcf Compare November 29, 2024 10:25
@spencerldixon spencerldixon force-pushed the feature/track_additional_paths_with_lastmod branch from c210fcf to 80ce6e4 Compare November 29, 2024 10:42
@github-actions github-actions bot added the test label Nov 29, 2024
@spencerldixon spencerldixon force-pushed the feature/track_additional_paths_with_lastmod branch from 0c987fa to b36727f Compare November 29, 2024 10:49
Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me from a front end perspective

@spencerldixon spencerldixon force-pushed the feature/track_additional_paths_with_lastmod branch from 0c650e0 to e645d9c Compare November 29, 2024 11:12
Copy link

Copy link
Contributor

@martyn-w martyn-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@spencerldixon spencerldixon merged commit 2be7113 into master Nov 29, 2024
26 checks passed
@spencerldixon spencerldixon deleted the feature/track_additional_paths_with_lastmod branch November 29, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review ruby Pull requests that update Ruby code test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants