Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak ordering on Assessment only page and Internships page to ignore case #4396

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Tweak ordering on Assessment only page and Internships page to ignore case #4396

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
747c19d
adapted ListingComponent to order providers regardless of letter case
sarahcrack Dec 2, 2024
627cfd5
removed case insentive sorting from ListingComponent and adapted rake…
sarahcrack Dec 3, 2024
d132933
removed date from internships and assessment only page template
sarahcrack Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/grouped_cards/listing_component.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def group_link_anchor(group)
end

def items(group)
@data.dig(group, "providers")
@data.dig(group, "providers").sort_by { |provider| provider["header"].to_s.downcase }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be more efficient to do the sort once when we generate the Yaml data (see lib/tasks/generate_assessment_only_providers.rake), rather than sort here which will run on every request of the page.

end

def description(group)
Expand Down
Loading