Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update postcode content on the mailing list #4433

Merged
merged 6 commits into from
Jan 6, 2025
Merged

Update postcode content on the mailing list #4433

merged 6 commits into from
Jan 6, 2025

Conversation

emmaachesongray
Copy link
Contributor

@emmaachesongray emmaachesongray commented Dec 12, 2024 •
edited
Loading

Trello card

https://trello.com/c/ML8z1D9w/7053

Context

We ran user research on the mailing list sign up, and changed some of the content on the postcode step.

Changes proposed in this pull request

Update the content below the question on the postcode page.

Guidance to review

@github-actions github-actions bot added ruby Pull requests that update Ruby code Config labels Dec 12, 2024
@github-actions github-actions bot added the test label Dec 12, 2024
Sarah-DfE
Sarah-DfE reviewed Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@Sarah-DfE Sarah-DfE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of teeny comments/suggestions @emmaachesongray

app/views/mailing_list/steps/_postcode.html.erb Outdated Show resolved Hide resolved
app/views/mailing_list/steps/_postcode.html.erb Outdated Show resolved Hide resolved
martyn-w
martyn-w previously approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@martyn-w martyn-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM (from tech perspective) - please get a content review too

@gemmadallmandfe
Copy link
Contributor

gemmadallmandfe commented Dec 16, 2024 •
edited
Loading

@emmaachesongray In the designs, we changed the question to What's your UK postcode (optional)? - have we moved away from this now?

spencerldixon
spencerldixon previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@spencerldixon spencerldixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gemmadallmandfe
Copy link
Contributor

@emmaachesongray Tiny comment - do you want to update the question in the events funnel so it is consistent?

  • Mailing list - What's your UK postcode? (optional)
  • Events - What is your UK postcode? (optional)

Otherwise, I'm happy with this from a front-end perspective so it can be merged if you get a tech review of the final version. I can't test the events funnel changes on the front end as there are no events in the dev environment currently so please check in staging that all is OK once merged next week

image

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

Review app deployed to https://get-into-teaching-app-review-4433.test.teacherservices.cloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Passed Quality Gate passed

Issues
12 New issues
10 Accepted issues

Measures
0 Security Hotspots
95.7% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarQube Cloud

@emmaachesongray
Copy link
Contributor Author

@Sarah-DfE please could you 2i the latest changes on this one from a content POV?

Sarah-DfE
Sarah-DfE approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@Sarah-DfE Sarah-DfE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good to me @emmaachesongray

martyn-w
martyn-w approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@martyn-w martyn-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@emmaachesongray emmaachesongray merged commit eaecf1b into master Jan 6, 2025
27 checks passed
@emmaachesongray emmaachesongray deleted the update-mailing-list-postcode branch January 6, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sarah-DfE Sarah-DfE Sarah-DfE approved these changes

@martyn-w martyn-w martyn-w approved these changes

@spencerldixon spencerldixon spencerldixon left review comments

@gemmadallmandfe gemmadallmandfe Awaiting requested review from gemmadallmandfe

Assignees
No one assigned
Labels
Config Review ruby Pull requests that update Ruby code test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emmaachesongray @gemmadallmandfe @martyn-w @spencerldixon @Sarah-DfE