Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create routes wizard logic #4443

Merged
merged 14 commits into from
Jan 15, 2025

Conversation

spencerldixon
Copy link
Collaborator

@spencerldixon spencerldixon commented Dec 17, 2024

Trello card

https://trello.com/c/Jw2OtlND/7109-add-routes-mapping-logic-to-routes-wizard?filter=member:spencerldixon

https://trello.com/c/XZir3FWf/7110-add-draft-content-summaries-for-each-route-to-routes-wizard-to-be-displayed-on-results-page?filter=member:spencerldixon

Context

We are introducing a new routes wizard

We want to ask candidates three simple questions and then display appropriate route information depending on their answers

We want to build the mapping that dictates which routes are shown on the results page based on the answers to the three questions

Changes proposed in this pull request

  • Store routes into teaching in a config/routes_into_teaching.yml file so it is editable by the content team
  • Create logic to select relevant routes depending on answers to questions
  • Adds draft content for each route

Guidance to review

@github-actions github-actions bot added ruby Pull requests that update Ruby code Config labels Dec 17, 2024
@spencerldixon spencerldixon marked this pull request as ready for review January 10, 2025 11:18
Copy link
Contributor

@martyn-w martyn-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks really good 👍

just check that its OK not to use value interpolation in titles, headings, fees etc.

@gemmadallmandfe
Copy link
Contributor

gemmadallmandfe commented Jan 15, 2025

@spencerldixon I've retested the logic and it all looks great to me so happy for this to be merged into the other branch

We have decided to remove two routes from the initial wizard though - not sure if that is easier to do this in this PR before you merge it (probably?) or in the consolidated one - up to you:

  • Undergraduate degree (followed by Assessment only) (line 106)
  • Undergraduate degree (followed by iQTS) (line 119)

Copy link

@spencerldixon spencerldixon merged commit cd6ba50 into feature/routes_wizard Jan 15, 2025
27 checks passed
@spencerldixon spencerldixon deleted the feature/routes_wizard_logic branch January 15, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config Review ruby Pull requests that update Ruby code test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants