why become a teacher new page #4444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ruby
emmaachesongray
temporarily deployed
to
review
GitHub Actions
Inactive
emmaachesongray
temporarily deployed
to
review
GitHub Actions
Inactive
emmaachesongray
commented
Dec 17, 2024
app/views/content/life-as-a-teacher/pay-and-benefits/why-teach/_article.html.erb
Outdated
Show resolved
Hide resolved
…/_article.html.erb
emmaachesongray
temporarily deployed
to
review
GitHub Actions
Inactive
There was a problem hiding this comment.
@emmaachesongray This looks great - have left a few comments
Let's discuss where this content sits with @Sarah-DfE on Thursday!
app/views/content/life-as-a-teacher/pay-and-benefits/_categories.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/pay-and-benefits/_categories.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/pay-and-benefits/why-teach.md
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/pay-and-benefits/why-teach/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/pay-and-benefits/why-teach/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/pay-and-benefits/why-teach/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/pay-and-benefits/why-teach/_article.html.erb
Outdated
Show resolved
Hide resolved
| <p>You’ll get more days holiday than people in many other professions. In school, full-time teachers work 195 days per year.</p> | ||
|
|
||
| <p>For comparison, you’d work 227 days per year (on average) if you worked full time in an office.</p> | ||
|
|
There was a problem hiding this comment.
Should we include a CTA at the end of the page - for mailing list perhaps? Or Steps?
Sarah-DfE
reviewed
Jan 6, 2025
| <%= render Categories::CardComponent.new(heading_tag: "h2", card: | ||
| OpenStruct.new( | ||
| title: "Why become a teacher", | ||
| description: "Explore the many reasons why you should become a teacher in England. From making a difference to exploring your creativity, holidays, pay, and much more.", |
There was a problem hiding this comment.
Not sure about this, it sounds a bit like they're exploring their creativity, holidays, pay etc
Maybe:
From making a difference from day 1, to exploring your creativity and benefitting from a competitive salary and generous holidays.
Might be a bit wordy now though!
| --- | ||
| title: Why become a teacher | ||
| description: |- | ||
| Explore the many reasons why you should become a teacher in England. From making a difference to exploring your creativity, holidays, pay, and much more. |
app/views/content/life-as-a-teacher/teaching-as-a-career/why-teach/_article.html.erb
Outdated
Show resolved
Hide resolved
|
|
||
| <h2 class="heading--box-blue">Use skills from your degree or previous career</h2> | ||
|
|
||
| <p>Teaching provides you with a great environment to use the skills and knowledge you’ve developed during a degree or a previous career. You’ll share your passion with your pupils and continue to learn as you teach.</p> |
There was a problem hiding this comment.
Worth a link to careers changers section here?
emmaachesongray
commented
Jan 7, 2025
app/views/content/life-as-a-teacher/teaching-as-a-career/_categories.html.erb
Outdated
Show resolved
Hide resolved
emmaachesongray
commented
Jan 7, 2025
app/views/content/life-as-a-teacher/teaching-as-a-career/why-teach.md
Outdated
Show resolved
Hide resolved
emmaachesongray
commented
Jan 7, 2025
app/views/content/life-as-a-teacher/teaching-as-a-career/why-teach/_article.html.erb
Outdated
Show resolved
Hide resolved
Co-authored-by: Sarah-DfE <103052329+Sarah-DfE@users.noreply.github.com>
emmaachesongray
commented
Jan 7, 2025
app/views/content/life-as-a-teacher/teaching-as-a-career/_categories.html.erb
Outdated
Show resolved
Hide resolved
emmaachesongray
commented
Jan 7, 2025
app/views/content/life-as-a-teacher/teaching-as-a-career/why-teach.md
Outdated
Show resolved
Hide resolved
Sarah-DfE
reviewed
Jan 8, 2025
...iews/content/life-as-a-teacher/change-careers/benefits-of-changing-careers/_article.html.erb
Outdated
Show resolved
Hide resolved
…-changing-careers/_article.html.erb Co-authored-by: Sarah-DfE <103052329+Sarah-DfE@users.noreply.github.com>
|
Review app deployed to https://get-into-teaching-app-review-4444.test.teacherservices.cloud |
|
emmaachesongray
had a problem deploying
to
review
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/MA9IVFdL/7037
Context
We identified a content gap on GIT. So we need to add more content about why users should become a teacher.
Changes proposed in this pull request
This PR adds a new page of content to the life as a teacher section to meet this content gap.
Guidance to review