Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update events link text #4474

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Update events link text #4474

merged 1 commit into from
Jan 9, 2025

Conversation

emmaachesongray
Copy link
Contributor

Trello card

https://trello.com/c/rmVdVuUI/7142

Context

We ran a split test before Christmas on the h1 on the event link text in the extra nav bar. The variant link performed better.

Changes proposed in this pull request

We want to implement the variant link text.

Guidance to review

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

@github-actions github-actions bot added the Review label Jan 9, 2025
Copy link
Collaborator

@spencerldixon spencerldixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@Sarah-DfE Sarah-DfE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@emmaachesongray emmaachesongray merged commit 139aaae into master Jan 9, 2025
28 checks passed
@emmaachesongray emmaachesongray deleted the update-events-link-text branch January 9, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants