Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the non-UK eligibility page #4475

Merged
merged 8 commits into from
Jan 14, 2025

Conversation

Sarah-DfE
Copy link
Collaborator

Trello card

https://trello.com/c/FtYRvf1o/7163-international-content-redesign-eligibility-page

Context

Updating the non-uk trainee eligibility page

Changes proposed in this pull request

Guidance to review

@github-actions github-actions bot added the content Content changes label Jan 9, 2025
@github-actions github-actions bot added the Review label Jan 9, 2025
@Sarah-DfE
Copy link
Collaborator Author

Just flagging this on line 18 of the front matter - guessing this shouldn't be here?

id: u0W7UTnGcc0
title: A video about why you should Train to Teach in England

@gemmadallmandfe
Copy link
Contributor

Just flagging this on line 18 of the front matter - guessing this shouldn't be here?

id: u0W7UTnGcc0 title: A video about why you should Train to Teach in England

If the Non-UK video is not supposed to be on that page (doesn't look like it), you can remove the reference to it in the front matter @Sarah-DfE

NB 4 lines need removing, not 2!

image

@Sarah-DfE Sarah-DfE added the policy sign off PRs that change the meaning of content in a way that requires sign off by the policy team label Jan 14, 2025
Copy link

@emmaachesongray emmaachesongray self-requested a review January 14, 2025 14:34
Copy link
Contributor

@emmaachesongray emmaachesongray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Sarah-DfE Sarah-DfE merged commit df46480 into master Jan 14, 2025
27 checks passed
@Sarah-DfE Sarah-DfE deleted the updates-to-non-uk-eligibility-page branch January 14, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content changes policy sign off PRs that change the meaning of content in a way that requires sign off by the policy team Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants