Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-uk citizen visas page updates #4477

Merged
merged 20 commits into from
Jan 16, 2025
Merged

non-uk citizen visas page updates #4477

merged 20 commits into from
Jan 16, 2025

Conversation

Sarah-DfE
Copy link
Collaborator

Trello card

https://trello.com/c/oDtDq7GP/7162-international-content-redesign-apply-for-your-visa-to-train-page

Context

Changes proposed in this pull request

Guidance to review

@github-actions github-actions bot added the content Content changes label Jan 10, 2025
@Sarah-DfE Sarah-DfE changed the title updating title non-uk citizen visas page updates Jan 10, 2025
Sarah-DfE
Sarah-DfE commented Jan 14, 2025
View reviewed changes
Copy link
Collaborator Author

@Sarah-DfE Sarah-DfE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rereviewing before sending to policy

@Sarah-DfE Sarah-DfE added the policy sign off PRs that change the meaning of content in a way that requires sign off by the policy team label Jan 15, 2025
@gemmadallmandfe gemmadallmandfe mentioned this pull request Jan 15, 2025
Closed
Sarah-DfE
Sarah-DfE commented Jan 16, 2025
View reviewed changes
app/views/content/non-uk-teachers/fees-and-funding-for-non-uk-trainees.md Outdated Show resolved Hide resolved
app/views/content/non-uk-teachers/visas-for-non-uk-trainees.md Outdated Show resolved Hide resolved
app/views/content/non-uk-teachers/fees-and-funding-for-non-uk-trainees.md Outdated Show resolved Hide resolved
app/views/content/non-uk-teachers/fees-and-funding-for-non-uk-trainees.md Outdated Show resolved Hide resolved
app/views/content/non-uk-teachers/fees-and-funding-for-non-uk-trainees.md Outdated Show resolved Hide resolved
app/views/content/non-uk-teachers/fees-and-funding-for-non-uk-trainees.md Outdated Show resolved Hide resolved
app/views/content/non-uk-teachers/fees-and-funding-for-non-uk-trainees.md Outdated Show resolved Hide resolved
@Sarah-DfE @gemmadallmandfe
Updating changes from Gemma and a policy tweak
1e2a7b7 
Co-authored-by: Gemma Dallman <87642394+gemmadallmandfe@users.noreply.github.com>
@Sarah-DfE @gemmadallmandfe
Tweaks from further review
d6cbc33 
Co-authored-by: Gemma Dallman <87642394+gemmadallmandfe@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

Review app deployed to https://get-into-teaching-app-review-4477.test.teacherservices.cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
11 New issues
8 Accepted issues

Measures
0 Security Hotspots
96.1% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarQube Cloud

gemmadallmandfe
gemmadallmandfe approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Sarah-DfE Sarah-DfE merged commit 89bca73 into master Jan 16, 2025
27 checks passed
@Sarah-DfE Sarah-DfE deleted the visa-to-train-to-teach-in-England branch January 16, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gemmadallmandfe gemmadallmandfe gemmadallmandfe approved these changes

Assignees
No one assigned
Labels
content Content changes policy sign off PRs that change the meaning of content in a way that requires sign off by the policy team Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sarah-DfE @gemmadallmandfe