Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sections to routes wizard completed page #4490
Add sections to routes wizard completed page #4490
Changes from all commits
d02756a
b394579
86a4e2f
6f91d38
3b7c2b8
612dc4c
d08fccd
d373266
982294e
f07cc6d
e99fd58
1ad108c
69e4e3f
cfec5b0
3de0e39
c7a45c0
8cf0ec6
831eb76
d4fbd6a
c38df1b
faa98ec
aa1de23
cc57754
618a3f6
4f00e08
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to have a heading level attributed to it @spencerldixon
I think it should be an h3 as it comes under the h2 of
Next steps
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, looking in production, this component does not have a heading eg on https://getintoteaching.education.gov.uk/life-as-a-teacher/teaching-as-a-career/career-progression so I'm presuming we would need to look at this separately?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed QuoteWithImageComponent to render a h3 by default, but I've set this as an option, so we can always override this with another value if needed elsewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to have a heading level attributed to it @spencerldixon
I think it should be an h3 as it comes under the h2 of
Next steps
?