Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create physical education page #4495

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

joegibb
Copy link
Collaborator

@joegibb joegibb commented Jan 17, 2025

https://trello.com/c/BuiPdY7D

We are creating a PE subject page to help people know what they can teach and help them get the information they need to know if teaching is the right career for them.

@github-actions github-actions bot added ruby Pull requests that update Ruby code content Content changes labels Jan 17, 2025
Copy link
Contributor

@emmaachesongray emmaachesongray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great - left a few comments.

What do you think about adding a teacher stories call out to link this page to the PE inspo page we have about managing behaviour in the classroom?

image

Copy link
Contributor

@emmaachesongray emmaachesongray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really great! Couple of tiny comments.

@joegibb joegibb added the policy sign off PRs that change the meaning of content in a way that requires sign off by the policy team label Jan 21, 2025
Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments for you @joegibb - looks good!

Copy link
Contributor

@emmaachesongray emmaachesongray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few tiny final comments/questions!

joegibb and others added 2 commits January 22, 2025 10:57
…-a-lesson.html.erb

Co-authored-by: emmaachesongray <168454683+emmaachesongray@users.noreply.github.com>
…es.html.erb

Co-authored-by: emmaachesongray <168454683+emmaachesongray@users.noreply.github.com>
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content changes policy sign off PRs that change the meaning of content in a way that requires sign off by the policy team Review ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants