Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Routes wizard early years and further education section #4506

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Routes wizard early years and further education section #4506

merged 1 commit into from
Jan 22, 2025

Conversation

spencerldixon
Copy link
Collaborator

Trello card

https://trello.com/c/qlszIoje/7280-add-early-years-and-further-education-to-routes-wizard-results?filter=member:spencerldixon

Context

We want to add in a section to the results page referencing early years and further education for some of the answer combinations (but not all)

To begin with, we want to show this content only if the user has selected No for the degree question

Changes proposed in this pull request

  • Adds helper for no_degree option selected
  • Adds section for early years and further education

Guidance to review

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Jan 22, 2025
@github-actions GitHub Actions
Copy link

Review app deployed to https://get-into-teaching-app-review-4506.test.teacherservices.cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
11 New issues
8 Accepted issues

Measures
0 Security Hotspots
95.4% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarQube Cloud

gemmadallmandfe
gemmadallmandfe approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Sarah-DfE are you happy with the content before this is merged into the main branch?

@spencerldixon spencerldixon merged commit 9e33acd into feature/routes_wizard Jan 22, 2025
28 checks passed
@spencerldixon spencerldixon deleted the feature/routes_wizard_early_years_section branch January 22, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gemmadallmandfe gemmadallmandfe gemmadallmandfe approved these changes

Assignees
No one assigned
Labels
Review ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spencerldixon @gemmadallmandfe