Set prometheus scrape port for workers #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saliceti
reviewed
Jul 11, 2024
aks/application/resources.tf
Outdated
| @@ -9,7 +9,7 @@ locals { | |||
| prometheus_scrape_annotations = var.enable_prometheus_monitoring ? { | |||
| "prometheus.io/scrape" = "true" | |||
| "prometheus.io/path" = "/metrics" | |||
| "prometheus.io/port" = var.web_port | |||
| "prometheus.io/port" = var.is_web ? var.web_port : 9394 | |||
There was a problem hiding this comment.
Can we create a worker_port variable?
RMcVelia
force-pushed
the
1889-scrape-custom-metrics
branch
from
e5c12f2 to
23af94e
Compare
RMcVelia
force-pushed
the
1889-scrape-custom-metrics
branch
from
23af94e to
aacddbd
Compare
saliceti
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When enabling prometheus monitoring for a deployment, the "prometheus.io/port" is hardcoded to the web_port
This is the wrong port for sidekiq workers
Changes proposed in this pull request
Update terraform to use the sidekiq port if not is_web
Could have made it optional to pass the port to the module, but I'm only currently aware of sidekiq workers requiring scraping.
Guidance to review
Currently DFE-Digital/schools-experience#3236 has been deployed from this branch, and metrics are being loaded to prometheus.
Checklist
Devopslabel