[2182] Allow null value in config map #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore the null variable when calculating hash to work around error:
Error: Invalid template interpolation value
│
│ on vendor/modules/aks/aks/application_configuration/resources.tf line 13, in locals:
│ 13: config_map_hash = sha1(join("-", [for k, v in local.config_map_data : "$***k***:$***v***"]))
│
│ The expression result is null. Cannot include a null value in a string
│ template.
We use the same behaviour for secrets
RMcVelia
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fix for error: https://github.com/DFE-Digital/get-into-teaching-app/actions/runs/12253181382/job/34182474422
The current workaround is to provide a non-null value: DFE-Digital/get-into-teaching-app#4417
Changes proposed in this pull request
Ignore the null variable when calculating hash. We use the same behaviour for secrets
Guidance to review
Test before applying DFE-Digital/get-into-teaching-app#4417
Checklist
Devopslabel