Add enable_logit option to application annotations #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saliceti
reviewed
Mar 25, 2024
RMcVelia
force-pushed
the
906-spike-application-log-shipping
branch
from
585b56c to
4981d76
Compare
saliceti
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add enable_logit option for the aks application module.
Setting to true will enable pod log forwarding for that deployment.
https://trello.com/c/WTWtPR8H/906-spike-application-log-shipping
Changes proposed in this pull request
application module terraform updates.
New variable enable_logit with default false
Guidance to review
Deploy an app using this branch and pass enable_logit with true value
Requires associated teacher-services-cloud PR to have been merged first.
Checklist
Devopslabel