[1707] Allow adding multiple DNS zones to a single front door #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each front door has a monthly cost so we can save by serving more domains instead of creating a new front door for each zone
saliceti
force-pushed
the
refactor_custom_domain_module
branch
from
118d87e to
10658d2
Compare
|
Closing as we agreed it would be better to create a new module instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Each front door has a monthly cost so we can save by serving more domains instead of creating a new front door for each zone
Changes proposed in this pull request
Add variable
add_to_front_doorto namespace all resources inside of front door and avoid clashes.Guidance to review
Test with TRS
Checklist
Devopslabel