Allow multiple point selection with shift key #1175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The OpenLayers select feature inherently allows users to select multiple features by holding the shift key when clicking on them. The
Map
component however fires the signal to open the plot window immediately after a selection is made preventing users from easily selecting multiple points to plot. A shift key check is added to the select function to signal that the user is selecting multiple points prevents the window from opening via amultiSelect
state variable. Likewise, an event listener is added to the main ocean navigator component to check that the shift key is released which modifies themultiSelect
state and allows the plot window to open.Why did you take this approach?
These checks allow the navigator to track when the user is selecting multiple points and delay the opening of the plot window.
Anything in particular that should be highlighted?
Multiple point selection is only enables when the user is selecting points to plot.
Checks
black .
.