Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortran auto-build #1182

Closed
wants to merge 22 commits into from
Closed

Fortran auto-build #1182

wants to merge 22 commits into from

Conversation

chiaraMaHe
Copy link
Collaborator

@chiaraMaHe chiaraMaHe commented Jul 24, 2024

Auto-Build system for the Fortran interface.
Use --enable-fortran while configure

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@chiaraMaHe chiaraMaHe marked this pull request as ready for review August 12, 2024 09:22
@Davknapp Davknapp added priority: high Should be solved as soon as possible workload: medium Would take a week or less labels Aug 12, 2024
Copy link
Collaborator

@holke holke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I can configure and build with and without enable-fortran.
The fortran interface is build.

Only one question:
Is this commented out intentionally?
"#include t8_fortran_specific.mk"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the "mo" in the name stand for?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it stands for 'module'. There was an error because there were two files with the name t8_fortran_interface.f90 in the old version and so it was named with the mo inside of the name. However, as there is now only one file with this name, I can change that

api/Makefile.am Outdated Show resolved Hide resolved
api/Makefile.am Outdated
src_libt8_la_FFLAGS = $(FFLAGS)

# Include the Fortran specific variables and rules
#include t8_fortran_specific.mk
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this be activated in follow-up PRs or should this be activated now?

Copy link
Collaborator Author

@chiaraMaHe chiaraMaHe Aug 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change that

t8_fortran_specific.mk Outdated Show resolved Hide resolved
t8_fortran_specific.mk Outdated Show resolved Hide resolved
@holke
Copy link
Collaborator

holke commented Aug 13, 2024

[ ] Should this use case be added to the github action?

Yes it should, i would propose to activate "enable-fortran" in all test cases by default.
will open a new issue.

Edit: see #1214

api/Makefile.am Outdated Show resolved Hide resolved
chiaraMaHe and others added 2 commits August 19, 2024 08:49
Co-authored-by: Sandro Elsweijer <49643115+sandro-elsweijer@users.noreply.github.com>
@chiaraMaHe chiaraMaHe assigned holke and unassigned chiaraMaHe Sep 19, 2024
@jmark
Copy link
Collaborator

jmark commented Sep 24, 2024

This PR is now covered by: #1255

@jmark jmark closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Follow-up PR Fortran priority: high Should be solved as soon as possible workload: medium Would take a week or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants