Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake CI [3/2] API testing #1204

Closed
wants to merge 11 commits into from
Closed

CMake CI [3/2] API testing #1204

wants to merge 11 commits into from

Conversation

sandro-elsweijer
Copy link
Collaborator

Describe your changes here:
Tests the fortran api. Needs the CMake build system linkage for Fortran

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@sandro-elsweijer sandro-elsweijer added CI Continuous Integration Follow-up PR help wanted draft Enhance the visibility that this is a draft. priority: low Should be solved eventually workload: medium Would take a week or less labels Aug 12, 2024
@holke
Copy link
Collaborator

holke commented Aug 13, 2024

Ah, did not see that when creating #1214
Would it already adress this issue?

@holke holke added the Fortran label Aug 13, 2024
@Davknapp Davknapp linked an issue Aug 13, 2024 that may be closed by this pull request
@sandro-elsweijer
Copy link
Collaborator Author

Ah, did not see that when creating #1214 Would it already adress this issue?

Yes. It is just waiting for the CMake implementation

@sandro-elsweijer sandro-elsweijer changed the base branch from main to feature-CMake_CI_2 August 13, 2024 14:55
@sandro-elsweijer
Copy link
Collaborator Author

I do not know what happened to the commit history of this branch but I will take a look at if as soon as the previous ones are merged.

Base automatically changed from feature-CMake_CI_2 to main August 23, 2024 08:22
@holke holke added the CMake Is about the CMake build system label Sep 9, 2024
@jmark
Copy link
Collaborator

jmark commented Sep 27, 2024

Has been merged into #1255.

@sandro-elsweijer Thanks for the preparatory work!

@jmark jmark closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration CMake Is about the CMake build system draft Enhance the visibility that this is a draft. Follow-up PR Fortran help wanted priority: low Should be solved eventually workload: medium Would take a week or less
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

CI: Activate "enable-fortran" in our CI tests
3 participants