Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code duplication #1290

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Remove code duplication #1290

merged 3 commits into from
Jan 7, 2025

Conversation

sandro-elsweijer
Copy link
Collaborator

@sandro-elsweijer sandro-elsweijer commented Oct 31, 2024

Describe your changes here:
Following the mm question I started removing the duplicated luts and fixed a bug on the way.
See #1289

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one)

@sandro-elsweijer sandro-elsweijer added cleanup Cleans the code priority: low Should be solved eventually workload: low Would take half a day or less labels Oct 31, 2024
@sandro-elsweijer sandro-elsweijer self-assigned this Oct 31, 2024
@sandro-elsweijer sandro-elsweijer force-pushed the fix-remove_deprecated branch 2 times, most recently from 7b7ce5f to fc69f08 Compare October 31, 2024 13:00
@sandro-elsweijer sandro-elsweijer linked an issue Oct 31, 2024 that may be closed by this pull request
@sandro-elsweijer sandro-elsweijer added the Bug For a bug in the Code label Oct 31, 2024
@sandro-elsweijer sandro-elsweijer marked this pull request as ready for review October 31, 2024 13:02
@sandro-elsweijer sandro-elsweijer removed their assignment Oct 31, 2024
@sandro-elsweijer
Copy link
Collaborator Author

@holke I requested a review from you, because @Davknapp and I checked the diverging tet LUTs manually, but maybe we missed a thing when removing the wrong one.

@sandro-elsweijer
Copy link
Collaborator Author

@holke As discussed I altered the duplication to macros which are linked to the eclasses.

@holke holke enabled auto-merge January 7, 2025 12:45
@holke holke merged commit d9fa12b into main Jan 7, 2025
20 checks passed
@holke holke deleted the fix-remove_deprecated branch January 7, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For a bug in the Code cleanup Cleans the code priority: low Should be solved eventually workload: low Would take half a day or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in tet LUT
2 participants