-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add t8_element_is_ghost function #1301
base: main
Are you sure you want to change the base?
Conversation
int | ||
t8_forest_element_is_leaf_or_ghost (const t8_forest_t forest, const t8_element_t *element, const t8_locidx_t local_tree, | ||
const int check_ghost) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like your idea of seperating the functionality of choosing the element array and searching the element array.
But I think this approach can be done even stricter, by passing the element_array as argument to the helper function.
t8_forest_element_is_leaf
and t8_forest_element_is_ghost
then have the task to chose the correct element array, which they then pass to the helper function, which determines if the element is included in the element array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve conflict and have a look at my comment regarding the separation of the helper functionality. I think we'd rather have the t8_element_array directly as input to the helper functionality
Describe your changes here:
Extend the t8_element_is_leaf functionality with t8_element_is_ghost and t8_element_is_leaf_or_ghost.
Given a ghost tree and an element this function returns true if and only if the element is a ghost element of that ghost tree.
Extended the test cases as well.
All these boxes must be checked by the reviewers before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
The reviewer executed the new code features at least once and checked the results manually
The code follows the t8code coding guidelines
New source/header files are properly added to the Makefiles
The code is well documented
All function declarations, structs/classes and their members have a proper doxygen documentation
All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)
Tests
Github action
The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)
All tests pass (in various configurations, this should be executed automatically in a github action)
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scp
to check the indentation of these files.License
doc/
(or already has one)