Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone scheme #1331

Open
wants to merge 58 commits into
base: main
Choose a base branch
from
Open

Standalone scheme #1331

wants to merge 58 commits into from

Conversation

ole-alb
Copy link
Contributor

@ole-alb ole-alb commented Dec 20, 2024

Describe your changes here:

Create a new standalone scheme for Vertex, LIne, Quad and Hex.
The face functions will be added in a second PR.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one)

Tag Label

  • The author added the patch/minor/major label in accordance to semantic versioning.

@ole-alb ole-alb changed the base branch from main to multiple-schemes-tests January 13, 2025 09:08
@ole-alb ole-alb added New feature Adds a new feature to the code priority: high Should be solved as soon as possible minor-release Merging this needs a new minor release labels Jan 16, 2025
@ole-alb ole-alb added the workload: medium Would take a week or less label Jan 16, 2025
lukasdreyer
lukasdreyer previously approved these changes Jan 16, 2025
@lukasdreyer lukasdreyer dismissed their stale review January 16, 2025 13:11

To prevent accidental merging

@lukasdreyer
Copy link
Collaborator

Please have a look if some of the forest tests can already be run with the standalone scheme

@ole-alb
Copy link
Contributor Author

ole-alb commented Jan 16, 2025

The forest tests: t8_gtest_element_if_leaf, t8_gtest_partition_data and t8_gtest_usesr_data already run with the current state of the standalone scheme.

@Davknapp Davknapp self-assigned this Jan 17, 2025
Copy link
Collaborator

@Davknapp Davknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a first look at the PR, I still need to look at the other files! But so far: Thank you for the good work!.

@Davknapp
Copy link
Collaborator

Had a look at the other files, liked them. If you address my comments we are ready to merge!

@Davknapp Davknapp assigned ole-alb and unassigned Davknapp Jan 17, 2025
@ole-alb ole-alb assigned Davknapp and unassigned ole-alb Jan 20, 2025
ole-alb and others added 3 commits January 21, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor-release Merging this needs a new minor release New feature Adds a new feature to the code priority: high Should be solved as soon as possible workload: medium Would take a week or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants