Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue that made dnn-input label cover 0 #1212

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

valadas
Copy link
Member

@valadas valadas commented Oct 25, 2024

Closes #1201

@valadas valadas added the bug Something isn't working label Oct 25, 2024
@valadas valadas added this to the 0.24.1 milestone Oct 25, 2024
Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valadas valadas merged commit f0fc104 into DNNCommunity:develop Oct 25, 2024
2 checks passed
valadas added a commit to valadas/dnn-elements that referenced this pull request Oct 26, 2024
What was corrected in DNNCommunity#1212 only handled the input being of type "number" but having the string "0" also caused the label issue. This PR fixes that.
valadas added a commit to valadas/dnn-elements that referenced this pull request Oct 26, 2024
valadas added a commit to valadas/dnn-elements that referenced this pull request Oct 26, 2024
Still about DNNCommunity#1212 one edge case is the number technically being a "Number" but it's value being NaN instead of undefined.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dnn-input numeric 0 label is not on top
2 participants