Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged v0.24.1 beta fixes back into develop #1219

Merged
merged 8 commits into from
Oct 26, 2024
Merged

Merged v0.24.1 beta fixes back into develop #1219

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
eeb35b1
Fixed an issue with 0 string float label
valadas Oct 26, 2024
6c9a762
Use coercion operation instead of hardly type ===
valadas Oct 26, 2024
46f4ba7
Merge pull request #1215 from valadas/0-string
valadas Oct 26, 2024
4eec435
Fixed an issue where label would not float with empty string
valadas Oct 26, 2024
b566c1c
Another correction
valadas Oct 26, 2024
0d9ae21
Merge pull request #1216 from valadas/empty-string-label-no-float
valadas Oct 26, 2024
c5e6b92
Also handle NaN for label
valadas Oct 26, 2024
4228538
Merge pull request #1217 from valadas/NaN-label
valadas Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/stencil-library/src/components/dnn-input/dnn-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,10 @@ export class DnnInput {
}

private shouldLabelFloat(): boolean {
if (this.type === "number" && isNaN(this.value as number)) {
return true;
}

if (this.focused) {
return false;
}
Expand All @@ -184,7 +188,7 @@ export class DnnInput {
return false;
}

if (this.type === "number" && this.value === 0){
if (this.value === 0 || this.value === "0") {
return false;
}

Expand Down
Loading