Made most input elements form aware #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes most elements that represent an input be aware of their surrounding form. It currently handles sending the values to the form and reacting to resets. I need to do at least 2 more PRs to complete this: 1. To make dnn-richtext also form aware (need to fix a bug before that) 2. To iron out validation UX/logic when validating a whole form. I though making those is separate PRs might make it easier to review.
david-poindexter
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes most elements that represent an input be aware of their surrounding form. It currently handles sending the values to the form and reacting to resets. I need to do at least 2 more PRs to complete this:
I though making those is separate PRs might make it easier to review.