Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved issue with --color-text not applying to inactive tab text color #998

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

david-poindexter
Copy link
Contributor

This PR resolves an issue with --color-text not applying to the inactive tab text color.

It also resolves a typo in a CSS var name that would prevent the style from applying to the visible (currently active) tab text color.

Resolves #997

@david-poindexter david-poindexter added the bug Something isn't working label Mar 8, 2024
@david-poindexter david-poindexter added this to the 0.23.4 milestone Mar 8, 2024
@david-poindexter david-poindexter requested a review from valadas March 8, 2024 22:29
@david-poindexter david-poindexter self-assigned this Mar 8, 2024
Copy link
Member

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks bood to me 😛

@valadas valadas merged commit 897d75c into DNNCommunity:develop Mar 8, 2024
2 checks passed
@david-poindexter
Copy link
Contributor Author

Looks bood to me 😛

@david-poindexter david-poindexter deleted the dnn-tabs-color-text branch March 8, 2024 23:53
@david-poindexter david-poindexter modified the milestones: 0.23.4, 0.24.0 Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

colorText property on dnn-tabs does not properly apply to inactive tab text
2 participants