Feature/infra setup #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/next.config.js
…vements (caching training data locallly, removing document orientation rotation)
tdooner
approved these changes
Apr 22, 2024
app/Dockerfile
Outdated
| ARG RUN_UID | ||
| ARG RUN_USER | ||
| ARG RUN_UID=${UID:-4000} | ||
| ARG RUN_USER=${USER:-'nodummy'} |
There was a problem hiding this comment.
I couldn't find any documentation that this syntax is supported here. Does it work?
| "outputs": {}, | ||
| "resources": [], | ||
| "check_results": null | ||
| } |
There was a problem hiding this comment.
This file shouldn't exist since the terraform state is stored in S3, right? We certainly don't want to commit the state here by accident.
| # size = 100, # Size in MiB | ||
| # mountOptions = ["defaults"] | ||
| # } | ||
| # ] |
There was a problem hiding this comment.
In general, we should remove code rather than commenting it out.
node_modules/.bin/tsc
Outdated
There was a problem hiding this comment.
It would be nice to add node_modules and .next to .gitignore so they aren't accidentally included again.
| @@ -20,7 +20,7 @@ locals { | |||
| # If enabled, the networks associated with this application's environments | |||
| # will have NAT gateways, which allows the service in the private subnet to | |||
| # make calls to the internet. | |||
| has_external_non_aws_service = false | |||
| has_external_non_aws_service = true | |||
There was a problem hiding this comment.
This might cost us $30/month per NAT gateway. I will log into AWS to see what they're projecting this thing to cost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Changes