Update make generate-openapi
to error when API violations occur
#1627
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updated the
make generate-openapi
command in Makefile to result in an error when API rule violations are detected.Motivation
Previously if we make a change to the CRDs that didn't follow the correct formatting to be populated correctly, no error would result when running commands locally (ex:
make generate
) and warnings wouldn't show up in CI.Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
tested here: #1626
datadogagent_types.go
. Ex: remove a listType, change something from camel case to snake case, remove a description or +optional line.make generate
Error: Warnings detected
and the command erroredChecklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label