Add mirror images #34
Conversation
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
src/mirror/datadog/agent/Dockerfile
Outdated
| @@ -0,0 +1 @@ | |||
| FROM datadog/agent | |||
There was a problem hiding this comment.
🟠 Code Quality Violation
always pin version to an image spec (...read more)
This rule dictates that Docker images should always be tagged with a specific version number. In Docker, an image tag represents a particular version of an image. The use of tags allows developers to have better control over which versions of an image are being used in their projects.
This is crucial because it ensures the consistency and reliability of the Docker environment. If an image is not tagged, Docker defaults to using the 'latest' version of the image. However, the 'latest' tag does not guarantee that the same version of an image will be used every time, which can lead to unexpected behavior or compatibility issues.
To comply with this rule, always specify a version number when pulling a Docker image. Instead of FROM debian, write FROM debian:unstable or FROM debian:10.3. This ensures that you are using a specific version of the image, providing a more predictable and stable environment for your project.
lloeki
force-pushed
the
lloeki/add-mirror-images
branch
from
092bf3d to
173abea
Compare
Rationale is: - mirror: provide 1:1 images, ideally automatically synced from their source registry; solves locality but not necessarily fitness for usage - service: provide "ready-to-use" images, possibly modified; solves both locality and fitness for usage
lloeki
force-pushed
the
lloeki/add-mirror-images
branch
from
173abea to
c6c0fa0
Compare
| @@ -0,0 +1 @@ | |||
| FROM datadog/agent | |||
There was a problem hiding this comment.
🟠 Code Quality Violation
always pin version to an image spec (...read more)
This rule dictates that Docker images should always be tagged with a specific version number. In Docker, an image tag represents a particular version of an image. The use of tags allows developers to have better control over which versions of an image are being used in their projects.
This is crucial because it ensures the consistency and reliability of the Docker environment. If an image is not tagged, Docker defaults to using the 'latest' version of the image. However, the 'latest' tag does not guarantee that the same version of an image will be used every time, which can lead to unexpected behavior or compatibility issues.
To comply with this rule, always specify a version number when pulling a Docker image. Instead of FROM debian, write FROM debian:unstable or FROM debian:10.3. This ensures that you are using a specific version of the image, providing a more predictable and stable environment for your project.
Fixes: #15