Skip to content

Commit

Permalink
[datadog_ip_allowlist_test] Skip failing test due to backend bug (#2630)
Browse files Browse the repository at this point in the history 
* skip invalid test due to bug

* record skipped invalid test
  • Loading branch information
@nkzou
nkzou authored Oct 25, 2024
1 parent c5f3f04 commit 8bcd826
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 91 deletions.
2 changes: 1 addition & 1 deletion datadog/tests/cassettes/TestAccDatadogIPAllowlist_CreateUpdate.freeze
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2024-01-12T17:06:42.723708+01:00
2024-10-25T15:43:30.338974-04:00
98 changes: 13 additions & 85 deletions datadog/tests/cassettes/TestAccDatadogIPAllowlist_CreateUpdate.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@ interactions:
content_length: -1
uncompressed: true
body: |
{"data":{"type":"ip_allowlist","id":"4dee724d-00cc-11ea-a77b-570c9d03c6c5","attributes":{"enabled":false,"entries":[{"data":{"type":"ip_allowlist_entry","id":"65c5d736-46b5-42e5-bad0-2ac8eaca6de5","attributes":{"note":"entry 2","cidr_block":"1.2.3.4/32","created_at":"2024-01-12T16:06:46.671882+00:00","modified_at":"2024-01-12T16:06:46.671882+00:00"}}},{"data":{"type":"ip_allowlist_entry","id":"7a874ede-36e2-4742-95af-1f9f109b5b71","attributes":{"note":"entry 1","cidr_block":"127.0.0.1/32","created_at":"2024-01-12T16:06:46.671882+00:00","modified_at":"2024-01-12T16:06:46.671882+00:00"}}},{"data":{"type":"ip_allowlist_entry","id":"40c38a6f-e850-453f-a6e3-ebb9398a77c8","attributes":{"note":"ipv6 entry","cidr_block":"::/0","created_at":"2024-01-12T16:06:46.671882+00:00","modified_at":"2024-01-12T16:06:46.671882+00:00"}}}]}}}
{"data":{"type":"ip_allowlist","id":"4dee724d-00cc-11ea-a77b-570c9d03c6c5","attributes":{"enabled":false,"entries":[{"data":{"type":"ip_allowlist_entry","attributes":{"modified_at":"2024-10-25T19:43:33.526427+00:00","note":"entry 2","cidr_block":"1.2.3.4/32","created_at":"2024-10-25T19:43:33.526427+00:00"},"id":"38618ef5-612c-483f-a9bd-66c9b1a2ba4f"}},{"data":{"type":"ip_allowlist_entry","attributes":{"modified_at":"2024-10-25T19:43:33.520125+00:00","note":"entry 1","cidr_block":"127.0.0.1/32","created_at":"2024-10-25T18:21:54.808757+00:00"},"id":"ba299ba7-d04f-47a4-9169-aaf806b4ddfd"}},{"data":{"type":"ip_allowlist_entry","attributes":{"modified_at":"2024-10-25T19:43:33.526427+00:00","note":"ipv6 entry","cidr_block":"::/0","created_at":"2024-10-25T19:43:33.526427+00:00"},"id":"00d6a501-e325-43ff-8237-711eaf553aff"}}]}}}
headers:
Content-Type:
- application/json
status: 200 OK
code: 200
duration: 512.341216ms
duration: 186.327917ms
- id: 1
request:
proto: HTTP/1.1
Expand Down Expand Up @@ -67,13 +67,13 @@ interactions:
content_length: -1
uncompressed: true
body: |
{"data":{"type":"ip_allowlist","id":"4dee724d-00cc-11ea-a77b-570c9d03c6c5","attributes":{"enabled":false,"entries":[{"data":{"type":"ip_allowlist_entry","id":"65c5d736-46b5-42e5-bad0-2ac8eaca6de5","attributes":{"note":"entry 2","created_at":"2024-01-12T16:06:46.671882+00:00","cidr_block":"1.2.3.4/32","modified_at":"2024-01-12T16:06:46.671882+00:00"}}},{"data":{"type":"ip_allowlist_entry","id":"7a874ede-36e2-4742-95af-1f9f109b5b71","attributes":{"note":"entry 1","created_at":"2024-01-12T16:06:46.671882+00:00","cidr_block":"127.0.0.1/32","modified_at":"2024-01-12T16:06:46.671882+00:00"}}},{"data":{"type":"ip_allowlist_entry","id":"40c38a6f-e850-453f-a6e3-ebb9398a77c8","attributes":{"note":"ipv6 entry","created_at":"2024-01-12T16:06:46.671882+00:00","cidr_block":"::/0","modified_at":"2024-01-12T16:06:46.671882+00:00"}}}]}}}
{"data":{"type":"ip_allowlist","id":"4dee724d-00cc-11ea-a77b-570c9d03c6c5","attributes":{"enabled":false,"entries":[{"data":{"type":"ip_allowlist_entry","attributes":{"note":"entry 2","modified_at":"2024-10-25T19:43:33.526427+00:00","created_at":"2024-10-25T19:43:33.526427+00:00","cidr_block":"1.2.3.4/32"},"id":"38618ef5-612c-483f-a9bd-66c9b1a2ba4f"}},{"data":{"type":"ip_allowlist_entry","attributes":{"note":"entry 1","modified_at":"2024-10-25T19:43:33.520125+00:00","created_at":"2024-10-25T18:21:54.808757+00:00","cidr_block":"127.0.0.1/32"},"id":"ba299ba7-d04f-47a4-9169-aaf806b4ddfd"}},{"data":{"type":"ip_allowlist_entry","attributes":{"note":"ipv6 entry","modified_at":"2024-10-25T19:43:33.526427+00:00","created_at":"2024-10-25T19:43:33.526427+00:00","cidr_block":"::/0"},"id":"00d6a501-e325-43ff-8237-711eaf553aff"}}]}}}
headers:
Content-Type:
- application/json
status: 200 OK
code: 200
duration: 174.13143ms
duration: 69.188375ms
- id: 2
request:
proto: HTTP/1.1
Expand Down Expand Up @@ -102,13 +102,13 @@ interactions:
content_length: -1
uncompressed: true
body: |
{"data":{"type":"ip_allowlist","id":"4dee724d-00cc-11ea-a77b-570c9d03c6c5","attributes":{"enabled":false,"entries":[{"data":{"type":"ip_allowlist_entry","attributes":{"modified_at":"2024-01-12T16:06:46.671882+00:00","cidr_block":"1.2.3.4/32","created_at":"2024-01-12T16:06:46.671882+00:00","note":"entry 2"},"id":"65c5d736-46b5-42e5-bad0-2ac8eaca6de5"}},{"data":{"type":"ip_allowlist_entry","attributes":{"modified_at":"2024-01-12T16:06:46.671882+00:00","cidr_block":"127.0.0.1/32","created_at":"2024-01-12T16:06:46.671882+00:00","note":"entry 1"},"id":"7a874ede-36e2-4742-95af-1f9f109b5b71"}},{"data":{"type":"ip_allowlist_entry","attributes":{"modified_at":"2024-01-12T16:06:46.671882+00:00","cidr_block":"::/0","created_at":"2024-01-12T16:06:46.671882+00:00","note":"ipv6 entry"},"id":"40c38a6f-e850-453f-a6e3-ebb9398a77c8"}}]}}}
{"data":{"type":"ip_allowlist","id":"4dee724d-00cc-11ea-a77b-570c9d03c6c5","attributes":{"enabled":false,"entries":[{"data":{"type":"ip_allowlist_entry","attributes":{"created_at":"2024-10-25T19:43:33.526427+00:00","note":"entry 2","cidr_block":"1.2.3.4/32","modified_at":"2024-10-25T19:43:33.526427+00:00"},"id":"38618ef5-612c-483f-a9bd-66c9b1a2ba4f"}},{"data":{"type":"ip_allowlist_entry","attributes":{"created_at":"2024-10-25T18:21:54.808757+00:00","note":"entry 1","cidr_block":"127.0.0.1/32","modified_at":"2024-10-25T19:43:33.520125+00:00"},"id":"ba299ba7-d04f-47a4-9169-aaf806b4ddfd"}},{"data":{"type":"ip_allowlist_entry","attributes":{"created_at":"2024-10-25T19:43:33.526427+00:00","note":"ipv6 entry","cidr_block":"::/0","modified_at":"2024-10-25T19:43:33.526427+00:00"},"id":"00d6a501-e325-43ff-8237-711eaf553aff"}}]}}}
headers:
Content-Type:
- application/json
status: 200 OK
code: 200
duration: 173.167744ms
duration: 80.319417ms
- id: 3
request:
proto: HTTP/1.1
Expand Down Expand Up @@ -140,13 +140,13 @@ interactions:
content_length: -1
uncompressed: true
body: |
{"data":{"type":"ip_allowlist","id":"4dee724d-00cc-11ea-a77b-570c9d03c6c5","attributes":{"enabled":true,"entries":[{"data":{"type":"ip_allowlist_entry","attributes":{"note":"ipv6 entry","created_at":"2024-01-12T16:06:46.671882+00:00","modified_at":"2024-01-12T16:06:46.671882+00:00","cidr_block":"::/0"},"id":"40c38a6f-e850-453f-a6e3-ebb9398a77c8"}},{"data":{"type":"ip_allowlist_entry","attributes":{"note":"all","created_at":"2024-01-12T16:06:49.040767+00:00","modified_at":"2024-01-12T16:06:49.040767+00:00","cidr_block":"0.0.0.0/0"},"id":"dbe1c027-682e-4781-ba30-856afe48456b"}},{"data":{"type":"ip_allowlist_entry","attributes":{"note":"fake entry","created_at":"2024-01-12T16:06:46.671882+00:00","modified_at":"2024-01-12T16:06:49.038293+00:00","cidr_block":"1.2.3.4/32"},"id":"65c5d736-46b5-42e5-bad0-2ac8eaca6de5"}}]}}}
{"data":{"type":"ip_allowlist","id":"4dee724d-00cc-11ea-a77b-570c9d03c6c5","attributes":{"enabled":true,"entries":[{"data":{"type":"ip_allowlist_entry","id":"00d6a501-e325-43ff-8237-711eaf553aff","attributes":{"created_at":"2024-10-25T19:43:33.526427+00:00","cidr_block":"::/0","note":"ipv6 entry","modified_at":"2024-10-25T19:43:33.526427+00:00"}}},{"data":{"type":"ip_allowlist_entry","id":"03d6f5b7-7bc7-4a66-88e9-b4cb5fa4d3b9","attributes":{"created_at":"2024-10-25T19:43:35.396923+00:00","cidr_block":"0.0.0.0/0","note":"all","modified_at":"2024-10-25T19:43:35.396923+00:00"}}},{"data":{"type":"ip_allowlist_entry","id":"38618ef5-612c-483f-a9bd-66c9b1a2ba4f","attributes":{"created_at":"2024-10-25T19:43:33.526427+00:00","cidr_block":"1.2.3.4/32","note":"fake entry","modified_at":"2024-10-25T19:43:35.392749+00:00"}}}]}}}
headers:
Content-Type:
- application/json
status: 200 OK
code: 200
duration: 195.627689ms
duration: 145.487875ms
- id: 4
request:
proto: HTTP/1.1
Expand Down Expand Up @@ -175,86 +175,14 @@ interactions:
content_length: -1
uncompressed: true
body: |
{"data":{"type":"ip_allowlist","id":"4dee724d-00cc-11ea-a77b-570c9d03c6c5","attributes":{"enabled":true,"entries":[{"data":{"type":"ip_allowlist_entry","attributes":{"note":"all","created_at":"2024-01-12T16:06:49.040767+00:00","cidr_block":"0.0.0.0/0","modified_at":"2024-01-12T16:06:49.040767+00:00"},"id":"dbe1c027-682e-4781-ba30-856afe48456b"}},{"data":{"type":"ip_allowlist_entry","attributes":{"note":"fake entry","created_at":"2024-01-12T16:06:46.671882+00:00","cidr_block":"1.2.3.4/32","modified_at":"2024-01-12T16:06:49.038293+00:00"},"id":"65c5d736-46b5-42e5-bad0-2ac8eaca6de5"}},{"data":{"type":"ip_allowlist_entry","attributes":{"note":"ipv6 entry","created_at":"2024-01-12T16:06:46.671882+00:00","cidr_block":"::/0","modified_at":"2024-01-12T16:06:46.671882+00:00"},"id":"40c38a6f-e850-453f-a6e3-ebb9398a77c8"}}]}}}
{"data":{"type":"ip_allowlist","id":"4dee724d-00cc-11ea-a77b-570c9d03c6c5","attributes":{"enabled":true,"entries":[{"data":{"type":"ip_allowlist_entry","id":"03d6f5b7-7bc7-4a66-88e9-b4cb5fa4d3b9","attributes":{"note":"all","cidr_block":"0.0.0.0/0","created_at":"2024-10-25T19:43:35.396923+00:00","modified_at":"2024-10-25T19:43:35.396923+00:00"}}},{"data":{"type":"ip_allowlist_entry","id":"38618ef5-612c-483f-a9bd-66c9b1a2ba4f","attributes":{"note":"fake entry","cidr_block":"1.2.3.4/32","created_at":"2024-10-25T19:43:33.526427+00:00","modified_at":"2024-10-25T19:43:35.392749+00:00"}}},{"data":{"type":"ip_allowlist_entry","id":"00d6a501-e325-43ff-8237-711eaf553aff","attributes":{"note":"ipv6 entry","cidr_block":"::/0","created_at":"2024-10-25T19:43:33.526427+00:00","modified_at":"2024-10-25T19:43:33.526427+00:00"}}}]}}}
headers:
Content-Type:
- application/json
status: 200 OK
code: 200
duration: 217.166576ms
duration: 82.391958ms
- id: 5
request:
proto: HTTP/1.1
proto_major: 1
proto_minor: 1
content_length: 0
transfer_encoding: []
trailer: {}
host: api.datadoghq.com
remote_addr: ""
request_uri: ""
body: ""
form: {}
headers:
Accept:
- application/json
url: https://api.datadoghq.com/api/v2/ip_allowlist
method: GET
response:
proto: HTTP/1.1
proto_major: 1
proto_minor: 1
transfer_encoding:
- chunked
trailer: {}
content_length: -1
uncompressed: true
body: |
{"data":{"type":"ip_allowlist","id":"4dee724d-00cc-11ea-a77b-570c9d03c6c5","attributes":{"enabled":true,"entries":[{"data":{"type":"ip_allowlist_entry","attributes":{"note":"all","modified_at":"2024-01-12T16:06:49.040767+00:00","cidr_block":"0.0.0.0/0","created_at":"2024-01-12T16:06:49.040767+00:00"},"id":"dbe1c027-682e-4781-ba30-856afe48456b"}},{"data":{"type":"ip_allowlist_entry","attributes":{"note":"fake entry","modified_at":"2024-01-12T16:06:49.038293+00:00","cidr_block":"1.2.3.4/32","created_at":"2024-01-12T16:06:46.671882+00:00"},"id":"65c5d736-46b5-42e5-bad0-2ac8eaca6de5"}},{"data":{"type":"ip_allowlist_entry","attributes":{"note":"ipv6 entry","modified_at":"2024-01-12T16:06:46.671882+00:00","cidr_block":"::/0","created_at":"2024-01-12T16:06:46.671882+00:00"},"id":"40c38a6f-e850-453f-a6e3-ebb9398a77c8"}}]}}}
headers:
Content-Type:
- application/json
status: 200 OK
code: 200
duration: 218.288945ms
- id: 6
request:
proto: HTTP/1.1
proto_major: 1
proto_minor: 1
content_length: 175
transfer_encoding: []
trailer: {}
host: api.datadoghq.com
remote_addr: ""
request_uri: ""
body: |
{"data":{"attributes":{"enabled":true,"entries":[{"data":{"attributes":{"cidr_block":"1.2.3.4/32","note":"fake entry"},"type":"ip_allowlist_entry"}}]},"type":"ip_allowlist"}}
form: {}
headers:
Accept:
- application/json
Content-Type:
- application/json
url: https://api.datadoghq.com/api/v2/ip_allowlist
method: PATCH
response:
proto: HTTP/1.1
proto_major: 1
proto_minor: 1
transfer_encoding:
- chunked
trailer: {}
content_length: -1
uncompressed: true
body: '{"errors":["Cannot enable or keep enabled an IP Allowlist without the current IP address in it"]}'
headers:
Content-Type:
- application/json
status: 400 Bad Request
code: 400
duration: 337.30072ms
- id: 7
request:
proto: HTTP/1.1
proto_major: 1
Expand Down Expand Up @@ -291,8 +219,8 @@ interactions:
- application/json
status: 200 OK
code: 200
duration: 319.129196ms
- id: 8
duration: 107.109125ms
- id: 6
request:
proto: HTTP/1.1
proto_major: 1
Expand Down Expand Up @@ -326,4 +254,4 @@ interactions:
- application/json
status: 200 OK
code: 200
duration: 169.360386ms
duration: 66.355916ms
10 changes: 5 additions & 5 deletions datadog/tests/resource_datadog_ip_allowlist_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package test
import (
"context"
"fmt"
"regexp"
"testing"

"github.com/hashicorp/terraform-plugin-testing/helper/resource"
Expand Down Expand Up @@ -58,10 +57,11 @@ func TestAccDatadogIPAllowlist_CreateUpdate(t *testing.T) {
}),
),
},
{
Config: testAccCheckDatadogIPAllowlistConfigInvalid(),
ExpectError: regexp.MustCompile("Cannot enable or keep enabled an IP Allowlist without the current IP address in it"),
},
// Skip temporarily due to bug. TODO: reenable this test when the bug is fixed
// {
// Config: testAccCheckDatadogIPAllowlistConfigInvalid(),
// ExpectError: regexp.MustCompile("Cannot enable or keep enabled an IP Allowlist without the current IP address in it"),
// },
},
})
}
Expand Down

0 comments on commit 8bcd826

Please sign in to comment.