[datadog_service_account] Fix : roles
attribute is now always updated
#2761
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2736
Current behaviour
If you ask for a service_account without roles
the drift will never be detected :
state.Roles
is nullservice-account
object by adding a role, at the next refresh of state, the state.Roles is still null and will not be refreshedIf you ask a service_account with at least one role, the issue doesn't happens as the State will not be null
Similarly if you import a service_account, Roles will never be loaded
Proposed behavior
Update in all cases the state.Roles from the result so we :
Risks of drift creation
When is called updateServiceAccountStateV2 ?
=> the change should not have drift impact
As the roles parameter is
optional
andcomputed
, if the user is requesting no specific roles and there is some automatic assignements it should not be seen as diff.