DASBO-7421 upadte authentification to datadome api from query param to using the… #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do not merge until the linked dashboard ticket is deployed |
BastienLedon
suggested changes
Oct 11, 2023
|
Hello @Simoouqas , |
Simoouqas
changed the title
Lauredg
reviewed
Oct 12, 2023
There was a problem hiding this comment.
LGTM! However I would like to test it before merging it.
When the API change is in production, we will test it, merge it and then I will make the release if that's ok with you @Simoouqas .
emmanuelCarre
approved these changes
Dec 8, 2023
Lauredg
approved these changes
Dec 13, 2023
|
@emmanuelCarre @Simoouqas I just tested it and it works :) |
BastienLedon
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this Pr we add a new authetication methode with apikey to use in the header as x-api-key,
we keep using the authetificaiton through the queryParam .
both authentication method should be available for customer but we recommend the header method .
documentation is updated .
for more details you can go here DASBO 7421
IT SHOULD NOT BE DEPLOYED UNTIL THE DASHBOARD TICKET IS ON PROD