Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add CHANGELOG.md #26

Merged
merged 3 commits into from
Aug 2, 2024
Merged

chore: add CHANGELOG.md #26

merged 3 commits into from
Aug 2, 2024

Conversation

lriberon
Copy link
Contributor

@lriberon lriberon commented Aug 1, 2024

Description

Add CHANGELOG.md file.

I followed the changelog notations from commonly used providers (e.g. AWS)

@lriberon lriberon requested a review from a team as a code owner August 1, 2024 15:03
@lriberon lriberon requested review from Lauredg and laurodd August 1, 2024 15:03
Lauredg
Lauredg previously approved these changes Aug 2, 2024
Copy link

@MickaelDatadome MickaelDatadome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nitpicking in the changelog.
go, as it's a verb should be marked as go IMO

CHANGELOG.md Outdated

ENHANCEMENTS:

- Upgrade go version and dependencies

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Upgrade go version and dependencies
- Upgrade `go` version and dependencies

CHANGELOG.md Outdated

- Upgrade go version and dependencies
- Improve error handling
- Improve godoc for each functions and constants

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Improve godoc for each functions and constants
- Improve `godoc` for each functions and constants

CHANGELOG.md Outdated

ENHANCEMENTS:

- Upgrade go version and dependencies

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Upgrade go version and dependencies
- Upgrade `go` version and dependencies

CHANGELOG.md Outdated

## 2.0.0 (2024-31-07)

BREAKING CHANGES:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
BREAKING CHANGES:
### BREAKING CHANGES:

CHANGELOG.md Outdated

- Change `whitelist` response to `allow`

ENHANCEMENTS:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ENHANCEMENTS:
### ENHANCEMENTS:

CHANGELOG.md Outdated

## 1.1.0 (2023-12-15)

BUG FIXES:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
BUG FIXES:
### BUG FIXES:

CHANGELOG.md Outdated

- Fix the authentication to DataDome API from query param to header

ENHANCEMENTS:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ENHANCEMENTS:
### ENHANCEMENTS:

Copy link

@MickaelDatadome MickaelDatadome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lriberon lriberon merged commit 4b78120 into master Aug 2, 2024
5 checks passed
@lriberon lriberon deleted the chore/add-changelog branch August 2, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants