feat: create datadome_endpoint resource #31
Conversation
| Read(ctx context.Context) ([]T, error) | ||
| type API[T any, I comparable] interface { | ||
| Create(ctx context.Context, params T) (*I, error) | ||
| Read(ctx context.Context, id I) (*T, error) |
There was a problem hiding this comment.
question: Now we are returning only one element?
There was a problem hiding this comment.
Yes, we do.
We were returning a list of elements due to the design of the custom_rules (and also trusted proxies): it does not have a route to return a resource by its ID.
The standard way (i.e. recommended by Hashicorp) is to call a route that retrieve a resource by its ID.
So I have changed the signature of the Read method to only return a single element, and I have moved the logic to find a custom_rule by its ID in the Read method (the logic moved from this file to this one)
| @@ -116,7 +123,7 @@ func (c *Client) Create(ctx context.Context, params CustomRule) (*int, error) { | |||
| req, err := http.NewRequestWithContext( | |||
| ctx, | |||
| "POST", | |||
| fmt.Sprintf("%s/custom-rules", c.HostURL), | |||
| c.HostURL, | |||
| return fmt.Errorf("status: %d, body: %s", res.StatusCode, body) | ||
| } | ||
|
|
||
| log.Printf("[DEBUG] %s\n", body) |
There was a problem hiding this comment.
question: should we keep this print here?
There was a problem hiding this comment.
I agree that the logs are not that useful.
I think that we should get rid of those logs and add terraform logs instead in a new ticket.
WDYT?
| return nil, err | ||
| } | ||
|
|
||
| log.Printf("[DEBUG] %+v\n", params) |
Description
datadome_endpointto the Terraform Provider with its Schema (empty CRUD functions for now)ClientEndpointfor endpoint managementendpoint.mddocumentation about thedatadome_endpointresource and its fieldsClienttoClientCustomRulein order to create a new client for endpointsReadfunction of theClientCustomRulein order to pass the ID of the custom rule we want to fetchHttpRequeststructure to do not be specific to the CustomRules onlyproviderConfigurefunction to provide 2 clients:ClientCustomRuleandClientEndpointHow to test?
The documentation
endpoint.mdfileYou should have a preview of the documentation
Acceptance Tests
The aim of this test is to validate that the custom_rule management feature was not impacted by the changes (i.e. renaming, different metadata).