-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): testnet faucet page with recaptcha #344
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloezxyy
requested review from
thedoublejay,
kyleleow,
pierregee,
fullstackninja864 and
lykalabrada
as code owners
November 2, 2023 08:11
✅ Deploy Preview for defimetascan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pierregee
suggested changes
Nov 6, 2023
…Research/metascan into chloe/testnet-faucet-ui
* feature(api): added api for faucet to allocate fund to user * added e2e test * fixed pr comments * added e2e for ratelimiting * added invalid address test case
fullstackninja864
suggested changes
Nov 24, 2023
* added loader and link to metascan * fixing issue that txnHash does not exist on metascan yet * reverted linking to metascan * revert unnecessayr change for sectionDesc * added more text * Update apps/web/src/pages/faucet/index.tsx Co-authored-by: Harsh R <53080940+fullstackninja864@users.noreply.github.com> * did UI comments & ran prettier * changed to using react-icon * removed react-spinners * set isLoading back to false * ui comments * Update apps/web/src/pages/faucet/index.tsx Co-authored-by: Harsh R <53080940+fullstackninja864@users.noreply.github.com> * Update apps/web/src/pages/faucet/index.tsx Co-authored-by: Harsh R <53080940+fullstackninja864@users.noreply.github.com> * used animate-spin * used tailwind color * revert isLoading value to false * changed to divs * will do button variants in a diff PR * added invalid address error text * enable button even after errors * print default error msg * made recaptcha dark * minor fixes --------- Co-authored-by: Harsh R <53080940+fullstackninja864@users.noreply.github.com> Co-authored-by: Harsh <harshrathi.dev@gmail.com>
fullstackninja864
temporarily deployed
to
AWS ECR
November 24, 2023 11:07 — with
GitHub Actions
Inactive
fullstackninja864
temporarily deployed
to
AWS ECR
November 24, 2023 11:35 — with
GitHub Actions
Inactive
fullstackninja864
temporarily deployed
to
AWS ECR
November 24, 2023 12:00 — with
GitHub Actions
Inactive
fullstackninja864
temporarily deployed
to
AWS ECR
November 24, 2023 12:09 — with
GitHub Actions
Inactive
fullstackninja864
temporarily deployed
to
AWS ECR
November 24, 2023 12:15 — with
GitHub Actions
Inactive
fullstackninja864
temporarily deployed
to
AWS ECR
November 24, 2023 12:29 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Faucet page for users to get testnet tokens. Includes:
To test:
PRIVATE_KEY
in/server/.env
file to a wallet address that has funds to send to the input wallet addressSECRET_KEY
for validating the recaptcha value (can get from @chloezxyy)Which issue(s) does this PR fixes?:
Fixes #
Additional comments?:
Developer Checklist: