Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui-ux): fix NaN display for gas used #348

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix(ui-ux): fix NaN display for gas used #348

merged 1 commit into from
Nov 9, 2023

Conversation

lykalabrada
Copy link
Contributor

What this PR does / why we need it:

Fixes displayed NaN on tx details page when gas and gas limit are both 0

Which issue(s) does this PR fixes?:

Fixes #347

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*

@netlify Netlify
Copy link

netlify bot commented Nov 9, 2023 •
edited
Loading

✅ Deploy Preview for defimetascan ready!

Name Link
🔨 Latest commit 73f3219
🔍 Latest deploy log https://app.netlify.com/sites/defimetascan/deploys/654c47ed14e95600082d308f
😎 Deploy Preview https://deploy-preview-348--defimetascan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance:
Accessibility:
Best Practices:
SEO:
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@lykalabrada lykalabrada self-assigned this Nov 9, 2023
@lykalabrada lykalabrada marked this pull request as ready for review November 9, 2023 02:46
@github-actions github-actions bot added the kind/fix Fix a bug label Nov 9, 2023
@pierregee pierregee merged commit e54a76b into main Nov 9, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fullstackninja864 fullstackninja864 fullstackninja864 approved these changes

@pierregee pierregee pierregee approved these changes

@nattadex nattadex Awaiting requested review from nattadex

@chloezxyy chloezxyy Awaiting requested review from chloezxyy

Assignees

@lykalabrada lykalabrada

Labels
kind/fix Fix a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NaN displaying on tx details page
3 participants
@lykalabrada @pierregee @fullstackninja864