Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Genaric radio implants are no longer syndicate branded #2159

Merged
merged 5 commits into from
Nov 17, 2024
Merged

Genaric radio implants are no longer syndicate branded #2159

merged 5 commits into from
Nov 17, 2024
+22 −20

Conversation

beck-thompson
Copy link
Contributor

About the PR

It didn't really make sense that they were syndicate branded! This also resolves the issue of finding a syndicate implant and not being able to do a search because it could be legal. Now all syndicate implants are illegal!

Media

image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Changelog

🆑 Beck Thompson

  • tweak: Generic radio implants are no longer syndicate branded.

@beck-thompson beck-thompson requested a review from a team as a code owner November 9, 2024 18:42
@github-actions github-actions bot added S: Needs Review Changes: YML Changes any yml files Changes: Localization Changes any ftl files and removed S: Needs Review labels Nov 9, 2024
@beck-thompson beck-thompson marked this pull request as draft November 9, 2024 19:12
@beck-thompson beck-thompson marked this pull request as ready for review November 9, 2024 21:42
@beck-thompson
Copy link
Contributor Author

The implant name and stuff is a little weird (You wont get the name unless you drop it and then pick it up again) but I think that's an unrelated issue

@deltanedas
Copy link
Member

yeah thats normal

@TadJohnson00
Copy link
Contributor

Direction has requested that you remove it from the uplink and at it to the logistics catalogue on the consideration that it lacks syndicate branding and has dubious legality.

@beck-thompson
Copy link
Contributor Author

Direction has requested that you remove it from the uplink and at it to the logistics catalogue on the consideration that it lacks syndicate branding and has dubious legality.

Execution has acknowledged Directions request and has made the required changes

@LadyDanger2743
Copy link

Direction has requested that you remove it from the uplink and at it to the logistics catalogue on the consideration that it lacks syndicate branding and has dubious legality.

Execution has acknowledged Directions request and has made the required changes

Beautiful. The Director approves. Something something glory to NanoTrasen.

@deltanedas deltanedas enabled auto-merge (squash) November 17, 2024 19:03
@deltanedas deltanedas merged commit 15c8f47 into DeltaV-Station:master Nov 17, 2024
11 checks passed
DisposableCrewmember42 pushed a commit to DisposableCrewmember42/Delta-v that referenced this pull request Nov 18, 2024
@beck-thompson @DisposableCrewmember42
Genaric radio implants are no longer syndicate branded (DeltaV-Statio…
d141366 
…n#2159)

* First commit

* Minor fix

* Requested changes

* grammar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltanedas deltanedas deltanedas approved these changes

Assignees
No one assigned
Labels
Changes: Localization Changes any ftl files Changes: YML Changes any yml files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@beck-thompson @deltanedas @TadJohnson00 @LadyDanger2743