Ensure the Horizontal state is set when buckling/unbuckling #2769
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/XS
deltanedas
requested changes
Jan 18, 2025
Ah bugger. Good point, didn't check :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Ensures the appearance data for the rotation is set to Horizontal when buckled, and Vertical when unbuckling. Fixes #2740
Please give it a test yourself.
I found that the best way to cause the bug is to give asphyx damage to the entity on the table, that seemed to work well.
Why / Balance
It's annoying for the up/down thing when you're buckled in.
Technical details
Bug effectively comes down to damage causing an evaluation of appearance and the rotations. The the client gets the message about apperance data being updated, the buckle system wants to set the rotation animation going but never sets the actual data that says "This entity is horizontal". So when the rotation system also gets this appearance change event, it just sets the rotation back to what it thinks is correct, which is vertical.
To fix, we just make the shared buckle system actually set the expected rotation when buckled and unbuckled.
Media
Before
https://github.com/user-attachments/assets/64c1d5c9-5e88-4cae-ab35-4bdc8f7eb1e4
After
https://github.com/user-attachments/assets/64d9be5a-40e1-48a1-8883-8eb94bceee74
Requirements
Breaking changes
N/A
Changelog
🆑