Pvaillancourt/196 video transcripts #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardalis
reviewed
Sep 13, 2022
| _memberRepository = memberRepository; | ||
| _getAllTextTracksService = getAllTextTracksService; | ||
| _httpClient = httpClient; | ||
| } |
There was a problem hiding this comment.
I was hoping the 7 constructor dependencies that were here would move closer to 1, not increase to 9, as part of the refactoring to move some of this into a separate service.
There was a problem hiding this comment.
Oh yeah, I'm definitely going to improve that. This will involve creating 1 or more classes. I didn't want to do to much in this one PR. I focused on refactoring at the method level. Next step, classes.
ardalis
approved these changes
Sep 13, 2022
|
Good incremental improvement. Hoping to see private methods moved into a separate service and number of constructor dependencies reduced accordingly in a future revision. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work towards #196 and may be merged and deployed if desired. I will make another PR for implementing what was discussed here.