Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced the structure of the file and also added some new sections #46

Merged
merged 4 commits into from
Oct 27, 2024

Conversation

milansamuel609
Copy link
Contributor

What does this PR do?

I have done little changes in structure like alignment and all and also added some new sections.

Changes I have done:-

  1. Enhanced the structure of the code
  2. Added Project flow chart
  3. Added good ways to code
  4. Added alternate way to contribute through GitHub desktop section

Fixes:[#45]

image

image

image

Type of change

How should this be tested?

I have checked through preview mode and without it thoroughly if there is any issue in alignment or anything else. I have not found any issue.

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @milansamuel609 for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

Copy link
Owner

@Devamani11D Devamani11D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project structure is incorrect. Refer readme file, .github doesnt contain all those files.
And make flowchart in some online flowchart making site like draw.io
Remaining everything is fine

@milansamuel609
Copy link
Contributor Author

Project structure is incorrect. Refer readme file, .github doesnt contain all those files. And make flowchart in some online flowchart making site like draw.io Remaining everything is fine

Sure I will change the flowchart and its structure too.

@milansamuel609
Copy link
Contributor Author

"I have added two remaning things from the structure that was run_in_localhost.js and video-thumbnail.png and also done some alignments in the structure to make it look more structured. I have not changed much. It is similar to the readme.md"

image

@Devamani11D
Copy link
Owner

Hey!
No need to keep 2 diagrams in the file and the first flowchart is incorrect.
And No need to keep the same flowchart of PS in contribution file again.
So , Remove those flowcharts and raise a PR with any other modifications you wanna add.
Thank you

@milansamuel609
Copy link
Contributor Author

Hey! No need to keep 2 diagrams in the file and the first flowchart is incorrect. And No need to keep the same flowchart of PS in contribution file again. So , Remove those flowcharts and raise a PR with any other modifications you wanna add. Thank you

I have added all other things that I want to add as I mention before. Just not able to add this one :(. I am sorry I am not able to do it properly. I will remove that flow diagram and PR again.

@milansamuel609
Copy link
Contributor Author

I have done all the enhancements. Please kindly check it once.

@Devamani11D
Copy link
Owner

Can you please send ss of what changes you have done.I am not able to see

@milansamuel609
Copy link
Contributor Author

Can you please send ss of what changes you have done.I am not able to see

Changes I have done before :-

Enhanced the structure of the code
Added good ways to code
Added alternate way to contribute through GitHub desktop section

image

image

@milansamuel609
Copy link
Contributor Author

I have done the changes. Please check them once. If they are ok please kindly merge the PR.

@milansamuel609
Copy link
Contributor Author

Please kindly merge my PR if all the changes are fine. Also please attach the label for gssoc ext and level

@Devamani11D
Copy link
Owner

git clone https://github.com//FinVeda.git

I didn't understand this.
Just give same project name

@milansamuel609
Copy link
Contributor Author

I have fixed the changes. Please kindly check it once. If the changes are fine please kindly merge the PR. Also please attach the gssoc ext and level label.

@milansamuel609
Copy link
Contributor Author

I have enhanced the file. Please kindly check the changes. If everything is fine please kindly merge and also add the gssoc extend and level label.

@milansamuel609
Copy link
Contributor Author

@Devamani11D Please kindly check the changes once if all the changes are fine please kindly merge this PR. Also please attach the gssoc extend and level label.

@milansamuel609
Copy link
Contributor Author

milansamuel609 commented Oct 25, 2024

@Devamani11D Please kindly merge the PR if all things are fine and also please add the label for gssoc extend and level also

Copy link
Owner

@Devamani11D Devamani11D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging , Thank you
But please have a look into the project when you are doing documentation for better understanding and easy merge.
🚀

@Devamani11D Devamani11D merged commit afebd6a into Devamani11D:main Oct 27, 2024
7 checks passed
Copy link

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

@milansamuel609
Copy link
Contributor Author

milansamuel609 commented Oct 27, 2024

@Devamani11D Please kindly add the gssoc extend and level label also

@Devamani11D Devamani11D added documentation Improvements or additions to documentation level1 Score of 10 points hacktoberfest-accepted hacktoberfest gssoc-ext labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation gssoc-ext hacktoberfest hacktoberfest-accepted level1 Score of 10 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants