-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced the structure of the file and also added some new sections #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thank you @milansamuel609 for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Project structure is incorrect. Refer readme file, .github doesnt contain all those files.
And make flowchart in some online flowchart making site like draw.io
Remaining everything is fine
Sure I will change the flowchart and its structure too. |
…ings are same as readme.md
Hey! |
I have added all other things that I want to add as I mention before. Just not able to add this one :(. I am sorry I am not able to do it properly. I will remove that flow diagram and PR again. |
I have done all the enhancements. Please kindly check it once. |
Can you please send ss of what changes you have done.I am not able to see |
I have done the changes. Please check them once. If they are ok please kindly merge the PR. |
Please kindly merge my PR if all the changes are fine. Also please attach the label for gssoc ext and level |
git clone https://github.com//FinVeda.git I didn't understand this. |
I have fixed the changes. Please kindly check it once. If the changes are fine please kindly merge the PR. Also please attach the gssoc ext and level label. |
I have enhanced the file. Please kindly check the changes. If everything is fine please kindly merge and also add the gssoc extend and level label. |
@Devamani11D Please kindly check the changes once if all the changes are fine please kindly merge this PR. Also please attach the gssoc extend and level label. |
@Devamani11D Please kindly merge the PR if all things are fine and also please add the label for gssoc extend and level also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging , Thank you
But please have a look into the project when you are doing documentation for better understanding and easy merge.
🚀
🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀 |
@Devamani11D Please kindly add the gssoc extend and level label also |
What does this PR do?
I have done little changes in structure like alignment and all and also added some new sections.
Changes I have done:-
Fixes:[#45]
Type of change
How should this be tested?
I have checked through preview mode and without it thoroughly if there is any issue in alignment or anything else. I have not found any issue.