Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Github SignIn #139

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

Anikesh02
Copy link
Contributor

Resolves #15 (comment)

PR Fixes:

Added GitHub Sign-In (Preview):

Arc.2024-10-09.09-34-35.mp4

Setup:

  1. Go to Firebase console and add a new sign-in provider (GitHub)

image

  1. Now go to your GitHub page and find the settings option.

  2. Click on Developer settings in the bottom:

image

  1. In Developer settings go to OAuth Apps and create a New OAuth App

  2. Register your new OAuth App

image

  1. For Authorization callback URL you can go to firebase console and in the GitHub provider (Present in Edit configuration of your github provider) settings you'll find:

image

  1. After adding the Authorization callback URL simply click on Register Application.

  2. After successfully registering your OAuth App you'll be provided with a client ID and client secret key (Which you can generate by clicking on Generate New Client Secret.

  3. Copy the client ID and client secret key and paste it in firebase GitHub configuration:

image

  1. You're all set! Just make sure that if you've used your GitHub primary email for Google signing (If the database already has your email stored when you used Google sign-in, it will create an error. Kindly make sure to use either Google sign-in or GitHub sign-in for one particular email. Duplicate emails will raise an error as the user can log in only with one email with one sign-in provider.

@DhanushNehru Kindly assign this PR to me and add "hacktoberfest" and "hacktoberfest-accepted" label to this PR and the issue solved .

Thank you !!

Copy link

vercel bot commented Oct 9, 2024

@Anikesh02 is attempting to deploy a commit to the Dhanush Nehru's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
custom-code-editor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 0:15am

@Anikesh02
Copy link
Contributor Author

@DhanushNehru Kindly review the PR and let me know if there's any change to be made and also please consider adding the labels.
Thank you !!

@DhanushNehru DhanushNehru merged commit ff85e32 into DhanushNehru:main Oct 10, 2024
3 checks passed
@DhanushNehru
Copy link
Owner

Hi @Anikesh02 , looks good if you can please create an issue mentioning this PR, to update the Readme so that people who set things in local from now on might be helpful.

You can update the Readme or anyone else can update accordingly

@Anikesh02
Copy link
Contributor Author

Hi @Anikesh02 , looks good if you can please create an issue mentioning this PR, to update the Readme so that people who set things in local from now on might be helpful.

You can update the Readme or anyone else can update accordingly

Created an issue for documentation of GitHub auth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporating Sign In with github
2 participants