Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing editor layout #49

Closed
wants to merge 9 commits into from
Closed

Conversation

doriroz
Copy link
Contributor

@doriroz doriroz commented May 27, 2024

changing the layout editor by creating a new sidebar to the right.
placing the position of the run button and the listdrop in the sidebar.
in addition, when error message is create it will display on the editor as a flow error text .
when the error text display, it can be close by the close button in the right side.
after i tried to close the error message and click the run button again the editor stay still and
no error message is displayed.
i expect the error message will display as long as there is an error,
but i don't know if that the way the editor should work.

Copy link

vercel bot commented May 27, 2024

@doriroz is attempting to deploy a commit to the Dhanush Nehru's projects Team on Vercel.

A member of the Team first needs to authorize it.

@DhanushNehru
Copy link
Owner

Seems some merge conflicts, can you please resolve it @doriroz

Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
custom-code-editor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 5:22pm

@DhanushNehru
Copy link
Owner

@doriroz seems still there are merge conflicts in few files

@doriroz
Copy link
Contributor Author

doriroz commented May 31, 2024

I can see the pullreqeust is in status 'await for authorization'.
i can not approve the deployment .

@DhanushNehru
Copy link
Owner

DhanushNehru commented May 31, 2024

Hi @doriroz vercel deployment approved, it seems there is an error in your code

But I can still see a merge conflict in this file src/pages/EditorComponent.js

@doriroz
Copy link
Contributor Author

doriroz commented Jun 24, 2024

Hi, i submitted my PR changes and i see it still waiting for approval.
can you please review on that PR and approve if its OK ?

@DhanushNehru
Copy link
Owner

Hi @doriroz seems the visualization looks odd in mobile view and also default code is not been pulled in your existing code which is already present, can you please check that

@doriroz
Copy link
Contributor Author

doriroz commented Jun 25, 2024

Hi....
i didn't fit the visualization looks to mobile view. on existing code it support with desktop view.
on my desktop view it look like below:

cd-editor

Copy link
Owner

@DhanushNehru DhanushNehru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check for the default code populated as well

@doriroz
Copy link
Contributor Author

doriroz commented Jun 29, 2024

Hi....
what do you mean by the default code populated ?

@DhanushNehru
Copy link
Owner

DhanushNehru commented Jun 30, 2024

In the existing app whenever you pick js, python or any other language, you will see the default code populated in the code editor.
https://custom-code-editor.vercel.app/
Can you incorporate those changes which are already present in your PR and raise a new one ? @doriroz

@doriroz doriroz deleted the cd-editor branch July 3, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants