Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caches pip download and env #656

Merged

Conversation

Relm-Arrowny
Copy link
Contributor

@Relm-Arrowny Relm-Arrowny commented Oct 2, 2024

#650 #629 I made an attempt caching the python env, it gain you about 30-90 per work flow build not sure if it is worth it or not. We can probably play the same game with the container part of the work-flow which is where the real bottle neck is.

@stan-dot Anyway see what you think,

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.62%. Comparing base (3a6693b) to head (629aead).
Report is 1 commits behind head on 629-speedup-github-actions.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           629-speedup-github-actions     #656   +/-   ##
===========================================================
  Coverage                       92.62%   92.62%           
===========================================================
  Files                              35       35           
  Lines                            1654     1654           
===========================================================
  Hits                             1532     1532           
  Misses                            122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stan-dot
Copy link
Contributor

stan-dot commented Oct 4, 2024

thanks,

this looks good

Monday I'll look into the container part - this 'cache-from:' is a field I missed at first
https://docs.docker.com/build/cache/backends/gha/

- name: Build and push
  uses: docker/build-push-action@v6
  with:
    context: .
    push: true
    tags: "<registry>/<image>:latest"
    cache-from: type=gha
    cache-to: type=gha,mode=max
    github-token: ${{ secrets.MY_CUSTOM_TOKEN }}
    
    ```

@stan-dot stan-dot merged commit 26be98c into DiamondLightSource:629-speedup-github-actions Oct 4, 2024
12 of 13 checks passed
@Relm-Arrowny Relm-Arrowny deleted the toy branch October 4, 2024 15:10
stan-dot pushed a commit that referenced this pull request Oct 30, 2024
#650 #629 I made an attempt caching the python env, it gain you about
30-90 per work flow build not sure if it is worth it or not. We can
probably play the same game with the container part of the work-flow
which is where the real bottle neck is.

@stan-dot Anyway see what you think,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants