Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Metal ID to experiment type #711

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Dec 11, 2024

Addresses #709

This PR adds the enum value for Metal ID to the experiment type

@rtuck99 rtuck99 force-pushed the 709_add_metal_id_to_experiment_type branch from e7acda0 to 9edb9a7 Compare December 11, 2024 15:31
@rtuck99 rtuck99 marked this pull request as ready for review December 11, 2024 15:32
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.88%. Comparing base (fd3c0a3) to head (9edb9a7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #711   +/-   ##
=======================================
  Coverage   86.88%   86.88%           
=======================================
  Files         102      102           
  Lines        6899     6900    +1     
=======================================
+ Hits         5994     5995    +1     
  Misses        905      905           
Components Coverage Δ
i24 SSX 72.69% <ø> (ø)
hyperion 96.88% <ø> (ø)
other 94.16% <100.00%> (+<0.01%) ⬆️

Copy link
Contributor

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - let's keep #709 open until the GDA changes have been built + deployed

@olliesilvester olliesilvester merged commit 0634f93 into main Dec 11, 2024
22 checks passed
@olliesilvester olliesilvester deleted the 709_add_metal_id_to_experiment_type branch December 11, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants