Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated package dependencies #296

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Updated package dependencies #296

wants to merge 28 commits into from

Conversation

tieneupin
Copy link
Contributor

@tieneupin tieneupin commented May 31, 2024

Part of continued work on issue #194.

Updated Murfey's package dependencies as follows:

  • Added defusedxml and importlib-metadata as explicit general dependencies (used by both client and server)
  • Added sqlalchemy[postgresql]<2 as an explicit server dependency
  • Freed up version restrictions for stomp-py and textual
  • Locked numpy to <2 while dependencies are upgrading

Additionally, updated the pre-commit hooks used to maintain the health of the repository.

  • pyproject-fmt will be fixed at v1.8.0 for now, as in >v2.x.x, they have changed their opinion and barred the use of sub-tables for all project-related keys
  • All other hooks updated to their latest versions

Validation Checks:

  • Murfey's demo server runs without issue. More extensive testing might be needed with an actual live session.

@tieneupin tieneupin requested a review from d-j-hatton May 31, 2024 18:01
@tieneupin tieneupin self-assigned this May 31, 2024
@d-j-hatton
Copy link
Contributor

I'll do some further testing of this one. Textual updates may affect how the client UI works (or if it works)

)
feedback_params.initial_model = str(rescaled_initial_model_path)
other_options["initial_model"] = str(rescaled_initial_model_path)
next_job = feedback_params.next_job

Check warning

Code scanning / CodeQL

Variable defined multiple times Warning

This assignment to 'next_job' is unnecessary as it is
redefined
before this value is used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants