-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add navbar tests, fix Jest/Babel configs #25
Conversation
Jest was declared as a module, but had no default export, this makes the Jest config a module. Babel has been made CommonJS, as it is the standard with this version of Babel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these tests and for the config updates.
As we've got rid of "type": "module"
in package.json
do we still need to change babel.config.js
to babel.config.cjs
?
I based this off an older master branch, but I'll test it without |
That should do it, but it's not wholly necessary - it still uses CJS module exports than proper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Next, I think I'll add workflow actions for automatically running unit tests, and possible move to Vitest!